add acf image_aspect_ratio_crop as related item (WP-902)#535
Merged
Conversation
dimitrystd
approved these changes
Jul 25, 2024
PavelLoparev
approved these changes
Jul 25, 2024
| { | ||
| return substr(md5(microtime(true)), 0, $length); | ||
| if ($length > 23) { | ||
| throw new \RuntimeException("Length should be less than 23 characters"); |
Contributor
There was a problem hiding this comment.
Less than or equal to according to the condition
dimitrystd
approved these changes
Jul 26, 2024
| wordpress.editor.mode: | ||
| class: Smartling\Helpers\GutenbergReplacementRule | ||
| arguments: | ||
| - ".+" |
Contributor
There was a problem hiding this comment.
This mean "everything". I don't know what GutenbergReplacementRule does, but want to draw your attention.
Contributor
Author
There was a problem hiding this comment.
You are correct, restricted to acf/.+
Contributor
Author
There was a problem hiding this comment.
Checked, the escape is not needed
PavelLoparev
approved these changes
Jul 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This appears to be a rarely used acf field type. The client should now be able to send related images from the related UI.