Skip to content

refactor ACF support (WP-971)#593

Merged
vsolovei-smartling merged 3 commits intomasterfrom
wp-971-acf-optimizations
Nov 24, 2025
Merged

refactor ACF support (WP-971)#593
vsolovei-smartling merged 3 commits intomasterfrom
wp-971-acf-optimizations

Conversation

@vsolovei-smartling
Copy link
Copy Markdown
Contributor

There should be no need to query db, local ACF stores work for ACF since early 2019

Copy link
Copy Markdown
Contributor

@PavelLoparev PavelLoparev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So now we only load "local" definitions and do not load "database" definitions? And we do not verify definitions now too?

@vsolovei-smartling
Copy link
Copy Markdown
Contributor Author

So now we only load "local" definitions and do not load "database" definitions? And we do not verify definitions now too?

Yes, in my tests the local definitions are enough for the plugin to work. This might be a somewhat risky update, if it goes wrong I'll restore the database definitions read with some optimisations.

Base automatically changed from wp-970-add-configuration-comments to master November 21, 2025 15:26
@vsolovei-smartling vsolovei-smartling merged commit c298b64 into master Nov 24, 2025
2 checks passed
@vsolovei-smartling vsolovei-smartling deleted the wp-971-acf-optimizations branch November 24, 2025 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants