misc improvements#324
Merged
Merged
Conversation
Smattr
commented
May 14, 2026
Comment on lines
+2770
to
+2771
| struct state **target = queue_handle_to_state_pptr(next_tail); | ||
| if (!__atomic_compare_exchange_n(target, &(struct state *){NULL}, s, | ||
| const struct state **target = queue_handle_to_state_pptr(next_tail); | ||
| if (!__atomic_compare_exchange_n(target, &(const struct state *){NULL}, s, |
Smattr
commented
May 14, 2026
Comment on lines
+3579
to
+3581
| assert(*count <= ((size_t)1) << STATE_SIZE_BITS && | ||
| "seen set size " | ||
| "exceeds total possible number of states"); | ||
| } | ||
| "seen set size exceeds total possible number of states"); | ||
| #endif |
These do not need to modified, either within the queue or after being dequeued.
This seems to be a persistent problem in the CMake world with no principled solution. Lets do users a favour and try to error early when we detect something like this.
Smattr
force-pushed
the
smattr/f6dbf97f-9cbc-43a9-9819-730e72f18b0d
branch
from
85c783a to
2b5c86b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.