Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
vasta-docs | e3a0608 | Commit Preview URL Branch Preview URL |
May 21 2026, 02:22 PM |
📝 WalkthroughWalkthroughThe PR migrates the project's code formatting toolchain from Prettier to oxfmt. It introduces oxfmt configuration, updates build scripts and dependencies, integrates the change into CI workflows, updates the VS Code development environment to recommend the oxc extension, and includes supporting documentation updates and version bumps. ChangesPrettier to Oxfmt Migration
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
package.json (1)
49-52: 💤 Low valueConfirm
formatshould fail fast onfmterrors.
pnpm run fmt && pnpm run lint:fixrunsoxfmt(write mode) first and only runs ESLint autofix if oxfmt exits 0. Sinceoxfmtwithout--checkrewrites files in place, a non-zero exit there usually signals a real parse/IO failure — short-circuiting is reasonable. Just calling out: if you ever want both passes to always run regardless of fmt outcome, use;instead of&&. No change required.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@package.json` around lines 49 - 52, The package.json "format" script currently uses "pnpm run fmt && pnpm run lint:fix" which intentionally short-circuits (runs lint:fix only if fmt exits 0); confirm this is desired, or if you want both steps to run regardless of oxfmt success change the connector to a semicolon so "fmt" (script name) and "lint:fix" always execute; note "fmt:check" remains the check-mode for oxfmt.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@package.json`:
- Line 62: The package.json currently lists "eslint-config-prettier" but your
ESLint setup (eslint.config.mjs) still extends it—either keep the devDependency
or remove the extend entry; to fix, decide which approach you want and make both
places consistent: if you want to keep using Prettier rules, leave
"eslint-config-prettier" in package.json and do nothing else, otherwise remove
the "eslint-config-prettier" entry from the "extends" array in eslint.config.mjs
(or remove the package.json devDependency if you remove the extends); reference
the package name "eslint-config-prettier" and the ESLint config file
"eslint.config.mjs" when making the matching change.
---
Nitpick comments:
In `@package.json`:
- Around line 49-52: The package.json "format" script currently uses "pnpm run
fmt && pnpm run lint:fix" which intentionally short-circuits (runs lint:fix only
if fmt exits 0); confirm this is desired, or if you want both steps to run
regardless of oxfmt success change the connector to a semicolon so "fmt" (script
name) and "lint:fix" always execute; note "fmt:check" remains the check-mode for
oxfmt.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 1892e741-5f2c-4c4b-bb46-baf6971f57b8
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (12)
.github/workflows/format-check.yml.gitignore.oxfmtrc.json.prettierignore.prettierrc.vscode/extensions.jsonREADME.mddocs/README.mddocs/content/1.getting-started/1.introduction.mddocs/content/3.contributing/1.local-development.mdpackage.jsonwrangler.toml
💤 Files with no reviewable changes (3)
- .prettierrc
- .prettierignore
- README.md
| @@ -62,8 +62,8 @@ | |||
| "eslint-config-prettier": "^9.1.2", | |||
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
rg -nP -C2 'eslint-config-prettier|"prettier"' --hidden -g '!pnpm-lock.yaml' -g '!node_modules'
fd -H -t f 'eslint.config' --exec cat {}Repository: Smef/vasta
Length of output: 1026
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "== package.json: prettier/oxfmt/devDeps/scripts =="
rg -n '"(prettier|oxfmt|eslint-config-prettier)"' package.json || true
rg -n '"scripts"\s*:' -n package.json || true
cat -n package.json | sed -n '1,140p' | sed -n '1,140p'Repository: Smef/vasta
Length of output: 3107
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "== eslint config: formatting-related references =="
ls -1 .
fd -H -t f 'eslint.config.*' -a . --exec sed -n '1,200p' {} || trueRepository: Smef/vasta
Length of output: 910
Don’t treat eslint-config-prettier as leftover—ESLint still extends it
eslint-config-prettier@^9.1.2 is still imported and included in extends in eslint.config.mjs, so it’s actively referenced (not dead weight). Remove it only if you also drop eslintConfigPrettier from the ESLint config; otherwise keep the devDependency.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@package.json` at line 62, The package.json currently lists
"eslint-config-prettier" but your ESLint setup (eslint.config.mjs) still extends
it—either keep the devDependency or remove the extend entry; to fix, decide
which approach you want and make both places consistent: if you want to keep
using Prettier rules, leave "eslint-config-prettier" in package.json and do
nothing else, otherwise remove the "eslint-config-prettier" entry from the
"extends" array in eslint.config.mjs (or remove the package.json devDependency
if you remove the extends); reference the package name "eslint-config-prettier"
and the ESLint config file "eslint.config.mjs" when making the matching change.
There was a problem hiding this comment.
Pull request overview
Switches the repository’s formatting toolchain from Prettier to Oxfmt and updates CI/editor configuration accordingly, with resulting whitespace-only formatting updates across docs/config files.
Changes:
- Replace Prettier scripts/dependency with Oxfmt (
fmt,fmt:check) and add.oxfmtrc.jsonconfiguration. - Update GitHub Actions format check workflow to run Oxfmt instead of Prettier.
- Add VS Code extension recommendation and adjust
.gitignore; apply formatter-driven whitespace changes in docs/config.
Reviewed changes
Copilot reviewed 8 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
wrangler.toml |
Normalizes TOML formatting for the assets directory entry. |
README.md |
Removes an extraneous blank line/whitespace in the example section. |
pnpm-lock.yaml |
Locks new oxfmt dependency and removes prettier. |
package.json |
Replaces Prettier scripts with Oxfmt scripts and updates pnpm version. |
docs/README.md |
Whitespace normalization (trailing spaces removed). |
docs/content/3.contributing/1.local-development.md |
Formatting cleanup (spacing/list numbering normalization). |
docs/content/1.getting-started/1.introduction.md |
Whitespace normalization for markdown content. |
.vscode/extensions.json |
Recommends the Oxc VS Code extension for contributors. |
.prettierrc |
Removed (no longer using Prettier). |
.prettierignore |
Removed; ignore patterns moved to Oxfmt config. |
.oxfmtrc.json |
Adds Oxfmt configuration (print width, ignores, Tailwind sorting settings). |
.gitignore |
Stops ignoring all of .vscode and allows committing extensions.json only. |
.github/workflows/format-check.yml |
Runs pnpm fmt:check (Oxfmt) instead of Prettier in CI. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Change to Oxfmt instead of prettier
Summary by CodeRabbit
Documentation
Chores