feat: rtree_rotated_nms#76
Conversation
Merging this PR will improve performance by ×2.8
Performance Changes
Comparing Footnotes
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #76 +/- ##
==========================================
- Coverage 98.77% 95.00% -3.78%
==========================================
Files 17 13 -4
Lines 2703 2745 +42
==========================================
- Hits 2670 2608 -62
- Misses 33 137 +104 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Smirkey
left a comment
There was a problem hiding this comment.
lgtm, will have a deeper look this we
i'll probably add a test against torch nms to verify we're correct,
been doing this manually, it's not great
Ready for review I think.
filter_and_sort_scoresfunction. Took the liberty of removing thenargument from the axis-aligned nms functions (hope it's ok)