use pkg-config to properly link to xkbcommon library when build without dlopen feature#198
use pkg-config to properly link to xkbcommon library when build without dlopen feature#198elinorbgr merged 2 commits intoSmithay:masterfrom semarie:pkgconfig
Conversation
…ut dlopen feature
|
for reference, the problem was originally reported to alacritty/alacritty#5422 |
There was a problem hiding this comment.
Thanks a lot, this is a clear oversight of when we added support for directly linking to xkbcommon rather than always dlopen-ing it.
I just have a small issue with the build-script logic, and could you also add an entry in the changelog, under the ## Unreleased section and as a ### Bugfixes subection (following the previous entries structure) ?
- always assumes pkg-config configuration will be present (and not just the library) - add CHANGELOG entry
|
feel free to told me if you present I push amended commit instead of adding new commits on top of previous one. |
elinorbgr
left a comment
There was a problem hiding this comment.
Okay, this is good for me, thanks!
Regarding the commits, I tend to try maintaining a succinct git history, so if you can amend your PR to make it as a single commit that would be appreciated. Otherwise I'll just squash-merge it.
to fix libxcbcommon linking on OpenBSD by using pkg-config when building without dlopen feature. For details see Smithay/client-toolkit#198
Fixes libxcbcommon linking on OpenBSD by using pkg-config when building without dlopen feature. For details see [1]. [1] - Smithay/client-toolkit#198
some OS (like OpenBSD or NetBSD) places third-parties libraries in no default paths, and requires explicit configuration to link to them. It makes smithay-client-toolkit difficult to build on such systems, as when not using
dlopenfeature, the build will fail.For example, with alacritty build:
Currently, there is no way to specify a directory in smithay-client-toolkit to found the library and properly link to it.
This PR uses
pkg-configcrate to configure build script to properly locate the library based on pkg-config configuration file.