Add unset method to input grab traits#1386
Merged
Merged
Conversation
Member
|
Seems like a good idea to me! |
`unset` is called when a grab is removed with `unset_grab` or replaced with `set_grab`. This fixes pop-os/cosmic-comp#403. There are a couple other grabs in Smithay and cosmic-comp that they run before unsetting the grab, that may cause issues if the grab is removed without running it. So this seems useful in general.
ids1024
changed the title
PointerGrab::unset methodunset method to input grab traits
This was referenced Apr 12, 2024
Drakulix
approved these changes
Apr 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PointerGrab::unsetis called when a grab is removed or replaced with another grab.This fixes pop-os/cosmic-comp#403. I've seen issues with one or two of cosmic-comp's grabs if something isn't cleaned up correctly when
unsetis called, so this should help with them, as well as some other Smithay grabs.I still need to add this for keyboard and touch grabs, but it seems workable.