xdg-toplevel-icon: allow replacing previously-set icon sizes#1945
Merged
cmeissl merged 1 commit intoSmithay:masterfrom Feb 26, 2026
Merged
Conversation
cmeissl
reviewed
Feb 26, 2026
Collaborator
cmeissl
left a comment
cmeissl
left a comment
There was a problem hiding this comment.
Beside the comment LGTM
Thanks!
cmeissl
reviewed
Feb 26, 2026
The icon sizes are replaced atomically with the newly-provided icons. Clients that bind to the interface in the future will get the new set of icons. However, existing client binds will not be notified, as it's unclear if this is allowed by the protocol. Closes Smithay#1944
kelnos
force-pushed
the
xdg-toplevel-icon-allow-replace-sizes
branch
from
6db73d6 to
3529eff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The icon sizes are replaced atomically with the newly-provided icons. Clients that bind to the interface in the future will get the new set of icons. However, existing client binds will not be notified, as it's unclear if this is allowed by the protocol.
Closes #1944
Checklist
[x] I agree to smithay's Developer Certificate of Origin.