fix(gles): use STREAM_DRAW for PIXEL_PACK_BUFFER (fixes #1595)#2002
Merged
Drakulix merged 1 commit intoSmithay:masterfrom Apr 20, 2026
Merged
fix(gles): use STREAM_DRAW for PIXEL_PACK_BUFFER (fixes #1595)#2002Drakulix merged 1 commit intoSmithay:masterfrom
Drakulix merged 1 commit intoSmithay:masterfrom
Conversation
|
Works with Niri on i7 L620, thanks |
Contributor
Author
|
@iggylari yeah it also works on my old intel core i2 |
Contributor
|
Confirming it fixes screenshots on niri on my Eee PC |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The GLES renderer was using GL_STREAM_READ when allocating PBOs for
glReadPixels operations (i don't know if this was a bug or intentional). However, PIXEL_PACK_BUFFER is used to pack
pixel data FROM the GPU (GPU writes, CPU reads), so using GL_STREAM_DRAW fixed it.
This caused screenshots in niri to fail with "failed to copy to output" and with debug logs:
on older CPUs (particularly Intel integrated graphics), where drivers
enforce the usage hint more strictly.
Checklist