Merged
Conversation
using sorcha functions, gets on sky rates for predict results
Had to be more explicit about when to print - or + for dec. Old method would always print + if result was close to zero (including negative). Also updating work on paralellising _get_on_sky_data
attempting to vectorise the code
Now outputs the magnitude of Obj_Sun_LTC_km
Collaborator
Author
|
The unit test failure is the same as the one Meg was getting a couple of days ago, not sure what the fix is |
Collaborator
|
This seems ready. |
Collaborator
|
This looks good to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #239
Gives users the option to output on-sky rates and geometry, such as range, heliocentric distance, phase angle, etc. for each prediction. Also a couple of minor changes, like a small fix to _convert_to_sg, and now checks if there are covariance columns before trying to find covariances.
Review Checklist for Source Code Changes