SMOODEV-946: .NET parity sweep — builder, circuit breaker, hooks, OnRejection, FastFirst#75
Merged
Merged
Conversation
…ejection, FastFirst Brings the .NET port closer to feature parity with the TS / Python / Rust / Go ports. Existing `SmooFetchOptions` + `SmooFetch.Create` factory remain for backwards compatibility — everything new is additive. New surface ----------- - `SmooFetchBuilder` (`SmooFetchBuilder.Create().With...().Build()`). - `LifecycleHooks` with `PreRequest`, `PostRequestOk`, `PostRequestErr`. - `CircuitBreakerOptions` + Polly v8 circuit breaker composed inside the resilience pipeline. Trips on the same predicates as the retry policy. - `OnRejectionCallback` / `OnRejectionDecision` (`Retry` / `RetryWithDelay` / `Abort` / `Skip` / `Default`) honored by the Polly `DelayGenerator`. - `RetryPolicy.FastFirst` — first retry fires with zero delay. - `RetryPolicy` converted to `record` so builder methods can use `with` to compose policies on the fly. Tests ----- New `SmooFetchBuilderTests` (7 cases) cover the builder happy path, PreRequest / PostRequestOk hook firing, the PostRequestErr documented behavior (only fires on transport-level throws, not HttpResponseError from the JSON reader), FastFirst skipping the initial backoff, OnRejection RetryWithDelay overriding the default delay, and the circuit breaker tripping after the failure threshold. Also included ------------- - `#[allow(dead_code)]` on `TestReply` in the Rust `auth_provider_tests.rs` added in PR #72 — the struct is only used as a `serde` deserialization target so cargo errors under `-D warnings` without the annotation. Out of scope (parked as follow-up) ---------------------------------- - Sliding-window rate limiter for .NET (callout from SMOODEV-946: "Rate limiter and FastFirst can ship as a follow-up if context is tight" — FastFirst is included; rate limiter is the only remaining gap). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 6bf9aaf The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes the biggest parity gap in the .NET port:
SmooFetchBuilderfluent API (SmooFetchBuilder.Create().With...().Build()).WithCircuitBreaker(failureThreshold, openDuration)).PreRequest,PostRequestOk,PostRequestErr.OnRejectioncallback withOnRejectionDecisiondiscriminated union (Retry/RetryWithDelay(delay)/Abort/Skip/Default) honored by the PollyDelayGenerator.FastFirstonRetryPolicy— first retry fires with zero delay.Existing
SmooFetchOptions+SmooFetch.Createfactory remain backwards-compatible — everything new is additive.RetryPolicyis now arecordso builder methods can usewithto layer overrides.Also includes a one-line
#[allow(dead_code)]onTestReplyin the Rustauth_provider_tests.rsadded in #72 — the struct is a serde-only target so cargo errors under-D warningswithout the annotation.Out of scope (follow-up)
Sliding-window rate limiter for .NET. The ticket explicitly called out that this could ship as a follow-up "if context is tight"; FastFirst is included here, leaving rate limiter as the only remaining gap.
Test plan
dotnet build— clean (3 frameworks)dotnet test— 27 passed (7 new builder cases)