Fix for passing target Domain without target DC or DC as FQDN instead of IP - also made -i accept comma separated list #180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances command-line argument handling for target domains and directory targets, adding support for comma-separated lists and domain name resolution to IP addresses.
- Added support for comma-separated list of directory targets in the
-iparameter - Implemented automatic DNS resolution for domain controllers when FQDN is provided instead of IP
- Enhanced domain controller selection logic to handle cases where only target domain is specified
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| Snaffler/Config.cs | Added parsing logic for comma-separated directory targets and improved debug logging |
| SnaffCore/ActiveDirectory/Helpers.cs | Removed unused import statements |
| SnaffCore/ActiveDirectory/AdData.cs | Added DNS resolution functionality and improved domain controller selection logic |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| //Console.WriteLine(dirTargetArg.Value); | ||
| string pathTarget = dirTargetArg.Value; | ||
| if (dirTargetArg.Value.Length > 4) | ||
| Mq.Degub("Disabled finding shares."); |
There was a problem hiding this comment.
Corrected spelling of 'Degub' to 'Debug'.
| Mq.Degub("Target path is " + dirTargetArg.Value); | ||
| foreach (string pathTarget in parsedConfig.PathTargets) | ||
| { | ||
| Mq.Degub("Targeting path:" + pathTarget); |
There was a problem hiding this comment.
Corrected spelling of 'Degub' to 'Debug'.
| catch (Exception ex) | ||
| { | ||
| // Handle DNS resolution errors | ||
| Console.WriteLine($"Resolution failed for '{input}': {ex.Message}"); |
There was a problem hiding this comment.
Direct console output should be replaced with the logging framework (Mq) for consistency with the rest of the codebase.
Suggested change
| Console.WriteLine($"Resolution failed for '{input}': {ex.Message}"); | |
| AdDataInstance.Mq.Enqueue($"Resolution failed for '{input}': {ex.Message}"); |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for passing target Domain without target DC or DC as FQDN instead of IP - also made -i accept comma separated list