Skip to content

Conversation

@norz3n
Copy link
Contributor

@norz3n norz3n commented Jan 31, 2025

Greetings, I decided to make a PKGBUILD to support Arch Linux builds for fun, I think you might be interested in it.

@the-label-bot

This comment was marked as off-topic.

@BrycensRanch BrycensRanch self-assigned this Jan 31, 2025
@BrycensRanch BrycensRanch added the enhancement New feature or request label Jan 31, 2025
@BrycensRanch
Copy link
Member

BrycensRanch commented Jan 31, 2025

Hi, thank you for your PR. I've noticed some minor issues with it. For example, the packaging directory doesn't need additional folders for one file. (the .spec file and PKGBUILD file should be right next to each other)

Additionally, the metainfo file is not only for RPM-based distros. It is used for software like gnome-software on Arch Linux and as per Arch Linux's packaging guidelines, it should be included for GNOME applications. https://wiki.archlinux.org/title/GNOME_package_guidelines

The Arch Linux package should use ./build.sh install --prefix /usr --dest-dir ${pkgdir} --skip compile for installing files. This unifies packaging, as a fix to the Install Target a fix for all packages.

Besides that, this PR looks great. Once the issues mentioned are ironed out, I will merge the pull request.

@BrycensRanch BrycensRanch changed the title Packaging: Add Arch Linux support build(PKGBUILD): add Arch Linux package Jan 31, 2025
@BrycensRanch BrycensRanch added the packaging Application packaging ie (RPM, deb, PKGBUILD) label Jan 31, 2025
- Add RPM spec file for Fedora/RHEL packaging
- Move Arch Linux PKGBUILD to root packaging directory
- Add desktop entry and AppStream metadata for Linux desktop integration
- Standardize package descriptions and dependencies across different package managers
@BrycensRanch
Copy link
Member

Also, I'd like to apologize for the delay. I've never used GitHub's "review" function yet. I reviewed your changes when they were made 6 hours ago then I realized why my review wasn't responded to. It wasn't marked as "finished" 😆

@BrycensRanch BrycensRanch added the waiting-on-op Waiting for original poster to respond label Feb 7, 2025
@BrycensRanch
Copy link
Member

Hello, @norz3n I have noticed there are problems with the install script such as it not creating a licenses directory and docs directory with the readme and PRIVACY.md. I am going to be addressing these problems tomorrow, I hope I can get a response regarding the package build failure with your current changes.

@norz3n
Copy link
Contributor Author

norz3n commented Feb 9, 2025

Hello, @norz3n I have noticed there are problems with the install script such as it not creating a licenses directory and docs directory with the readme and PRIVACY.md. I am going to be addressing these problems tomorrow, I hope I can get a response regarding the package build failure with your current changes.

Okay. I'll fix that in the near future.

BrycensRanch added a commit that referenced this pull request Feb 12, 2025
Unblocks #56 build(PKGBUILD): add Arch Linux package
@BrycensRanch
Copy link
Member

Hi, @norz3n ! This pull request has been unblocked by commit 411e3ec . Looking forward to an Arch Linux package. :)

@BrycensRanch
Copy link
Member

Thanks to commit 7c48244 SnapX's icons are now installed.

@BrycensRanch BrycensRanch added linux Relating to Linux stale Inactive labels Feb 19, 2025
@BrycensRanch
Copy link
Member

BrycensRanch commented Feb 19, 2025

Hi, the build log I provided here is currently going to expire in 11 days.

I've added the stale label as my reviews haven't been addressed. I want this pull request merged as recent crash reports from testers are considerably from Arch Linux users.

I see you've permitted me to edit your PR. I am open to all discussions, but if there is no activity within a week, I will submit a commit that will help ease my concerns and then merge this PR and I continue as the maintainer of the AUR package as hoped.
image

@github-actions github-actions bot removed the stale Inactive label Feb 20, 2025
…x pkg

I also removed some of the makedepends. SnapX only needs .NET 9 & NativeAOT to build. 

Signed-off-by: Brycen G <brycengranville@outlook.com>
I know this is confusing, lol. However, all the SnapX binaries have dependency on the libraries in /usr/lib/snapx hence snapx-ui relies on the snapx package plus the NativeMessagingHost for the Chrome extension. I will push out an update to the packaging to fix these flaws.

Signed-off-by: Brycen G <brycengranville@outlook.com>
@BrycensRanch
Copy link
Member

I have made the necessary changes and the PKGBUILD now builds. Congrats.

image

@BrycensRanch BrycensRanch merged commit 0072b18 into SnapXL:develop Feb 25, 2025
4 checks passed
@BrycensRanch BrycensRanch removed the waiting-on-op Waiting for original poster to respond label Feb 25, 2025
@BrycensRanch
Copy link
Member

BrycensRanch commented May 29, 2025

Hello, your work has been deployed to https://aur.archlinux.org/packages/snapx-ui ! Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request linux Relating to Linux packaging Application packaging ie (RPM, deb, PKGBUILD)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants