Ensure node ids are always selected into the same split#104
Merged
kmontemayor2-sc merged 14 commits intomainfrom Jun 25, 2025
Merged
Ensure node ids are always selected into the same split#104kmontemayor2-sc merged 14 commits intomainfrom
kmontemayor2-sc merged 14 commits intomainfrom
Conversation
Collaborator
Author
|
/unit_test |
Contributor
GiGL Automation@ 02:38:55UTC : 🔄 @ 03:06:03UTC : ❌ Workflow failed. |
Collaborator
Author
|
/unit_test |
Collaborator
Author
|
/integration_test |
Collaborator
Author
|
/e2e_test |
Contributor
GiGL Automation@ 03:53:41UTC : 🔄 @ 04:27:15UTC : ✅ Workflow completed successfully. |
Contributor
GiGL Automation@ 03:53:44UTC : 🔄 @ 04:34:46UTC : ✅ Workflow completed successfully. |
Contributor
GiGL Automation@ 03:53:48UTC : 🔄 @ 05:23:37UTC : ✅ Workflow completed successfully. |
nshah-sc
reviewed
Jun 20, 2025
nshah-sc
approved these changes
Jun 23, 2025
svij-sc
reviewed
Jun 23, 2025
Collaborator
Author
|
/unit_test |
Contributor
GiGL Automation@ 23:20:25UTC : 🔄 @ 23:43:39UTC : ❌ Workflow failed. |
svij-sc
reviewed
Jun 23, 2025
Collaborator
Author
|
/unit_test |
Contributor
GiGL Automation@ 17:03:47UTC : 🔄 @ 17:25:55UTC : ❌ Workflow failed. |
svij-sc
reviewed
Jun 24, 2025
Collaborator
Author
|
/unit_test |
Contributor
GiGL Automation@ 20:41:18UTC : 🔄 @ 21:06:43UTC : ❌ Workflow failed. |
svij-sc
approved these changes
Jun 24, 2025
Collaborator
svij-sc
left a comment
svij-sc
left a comment
There was a problem hiding this comment.
Thanks for the iterations
kmontemayor2-sc
commented
Jun 24, 2025
Collaborator
Author
|
/unit_test |
Contributor
GiGL Automation@ 22:10:49UTC : 🔄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
val_numandtest_numas floats - since we can't guarantee counts easily anymore.The issue with our previous splitting logic, is that even though a given node id would always have the same hash on different machines, since we sorted the hashed, it's "position" may be different and so it may be selected into different splits.
For instance, let's assume the hash function is the identity, and
rank_0_nodes: [0, 1, 2, 3] rank_1_nodes: [3, 4, 5, 6]On rank 0,
3would be selected into Test, as its hash value is the greatest sorted, while it would be in train on rank 1.Now what we do is fine the globally largest/smallest hash and then normalize the hash values per machine.
We then select the nodes based on the normalized values, since the hashes are consistent, and they get normalized the same, the same node id will be selected into the same split always now.