Support / as an overload on Uri, like Pathlib#224
Merged
kmontemayor2-sc merged 9 commits intomainfrom Aug 8, 2025
Merged
Conversation
kmontemayor2-sc
requested review from
mkolodner-sc,
nshah-sc,
svij-sc and
yliu2-sc
as code owners
Collaborator
Author
|
/unit_test |
Contributor
GiGL Automation@ 01:37:52UTC : 🔄 @ 02:20:27UTC : ✅ Workflow completed successfully. |
Collaborator
Author
|
/integration_test |
Collaborator
Author
|
/e2e_test |
Contributor
GiGL Automation@ 15:45:42UTC : 🔄 @ 17:16:46UTC : ✅ Workflow completed successfully. |
Contributor
GiGL Automation@ 15:45:43UTC : 🔄 @ 16:37:35UTC : ✅ Workflow completed successfully. |
svij-sc
reviewed
Jul 29, 2025
svij-sc
approved these changes
Jul 31, 2025
Collaborator
svij-sc
left a comment
svij-sc
left a comment
There was a problem hiding this comment.
Approving as non blocking.
But, as a reviewer comment on readability stands - I would prefer us not to not use parameterized as a "swiss army knife", it is nice for what it is and we should use it when needed - in this case its inducing extra unnecessary effort for the reader.
Collaborator
Author
|
/unit_test |
Contributor
GiGL Automation@ 18:42:26UTC : 🔄 @ 19:24:36UTC : ✅ Workflow completed successfully. |
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added truediv method on URI, returning an instance of
Self.Also updated some typignn things on URI, to return
typing_extensions.Selfinstead ofURI.This way,
LocalUri.join("foo")is aLocalURI, not aURI.Added tests for the above features.