Enforce exported config is to GCS.#243
Conversation
svij-sc
left a comment
There was a problem hiding this comment.
Lets also update the notebook cells ?
|
ping on
|
I'd prefer not to do this - we do require the resource config to be on GCS,. and Does it hurt to have the additional few lines of code here? |
There was a problem hiding this comment.
Does it hurt to have the additional few lines of code here?
Readability yes, otherwise no - the user can always change cells to what they want if they dont conform to what we have. (non-blocking)
Have we at least validated that we can the two notebooks after this change?
I'll do some testing (on qwiklabs ideally...) with this change and without the notebooks updated. If the notebooks break when updated I will not update them. |
svij-sc
left a comment
There was a problem hiding this comment.
thanks, as long as this is tested and works
|
FYI, I am doing a release: #253 |
As disscussed offline, require GCS exports for the generated resource config.
Also update notebooks to run the scripts on-the-fly.
We will need to revert some of these changes in the future