Skip to content

Enforce exported config is to GCS.#243

Merged
kmontemayor2-sc merged 32 commits intomainfrom
kmonte/enforce-gcs
Aug 1, 2025
Merged

Enforce exported config is to GCS.#243
kmontemayor2-sc merged 32 commits intomainfrom
kmonte/enforce-gcs

Conversation

@kmontemayor2-sc
Copy link
Copy Markdown
Collaborator

@kmontemayor2-sc kmontemayor2-sc commented Jul 30, 2025

As disscussed offline, require GCS exports for the generated resource config.

Also update notebooks to run the scripts on-the-fly.

We will need to revert some of these changes in the future

Copy link
Copy Markdown
Collaborator

@svij-sc svij-sc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets also update the notebook cells ?

Comment thread examples/tutorial/KDD_2025/lab_instructions.md Outdated
Comment thread scripts/bootstrap_resource_config.py Outdated
Comment thread examples/tutorial/KDD_2025/lab_instructions.md Outdated
@svij-sc
Copy link
Copy Markdown
Collaborator

svij-sc commented Jul 31, 2025

ping on

Lets also update the notebook cells ?

@kmontemayor2-sc
Copy link
Copy Markdown
Collaborator Author

Lets also update the notebook cells ?

I'd prefer not to do this - we do require the resource config to be on GCS,. and GIGL_TEST_DEFAULT_RESOURCE_CONFIG may point to a local uri (even if it wont in practice for the tutorial run through.

Does it hurt to have the additional few lines of code here?

Copy link
Copy Markdown
Collaborator

@svij-sc svij-sc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it hurt to have the additional few lines of code here?

Readability yes, otherwise no - the user can always change cells to what they want if they dont conform to what we have. (non-blocking)

Have we at least validated that we can the two notebooks after this change?

@kmontemayor2-sc
Copy link
Copy Markdown
Collaborator Author

Have we at least validated that we can the two notebooks after this change?

I'll do some testing (on qwiklabs ideally...) with this change and without the notebooks updated.

If the notebooks break when updated I will not update them.

Copy link
Copy Markdown
Collaborator

@svij-sc svij-sc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, as long as this is tested and works

@svij-sc
Copy link
Copy Markdown
Collaborator

svij-sc commented Aug 1, 2025

FYI, I am doing a release: #253
I can re-release after this is in

@kmontemayor2-sc kmontemayor2-sc marked this pull request as ready for review August 1, 2025 04:59
@kmontemayor2-sc kmontemayor2-sc added this pull request to the merge queue Aug 1, 2025
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Aug 1, 2025
@kmontemayor2-sc kmontemayor2-sc added this pull request to the merge queue Aug 1, 2025
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Aug 1, 2025
@kmontemayor2-sc kmontemayor2-sc added this pull request to the merge queue Aug 1, 2025
Merged via the queue into main with commit aec493c Aug 1, 2025
5 checks passed
@kmontemayor2-sc kmontemayor2-sc deleted the kmonte/enforce-gcs branch August 1, 2025 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants