Use clamp with bincount approach#281
Merged
kmontemayor2-sc merged 6 commits intomainfrom Aug 23, 2025
Merged
Conversation
Merged
svij-sc
reviewed
Aug 19, 2025
svij-sc
reviewed
Aug 19, 2025
mkolodner-sc
approved these changes
Aug 20, 2025
svij-sc
approved these changes
Aug 22, 2025
Collaborator
Author
|
/unit_test |
Collaborator
Author
|
/integration_test |
Collaborator
Author
|
/test |
Contributor
GiGL Automation@ 19:08:12UTC : 🔄 @ 19:47:08UTC : ✅ Workflow completed successfully. |
Contributor
GiGL Automation@ 19:08:18UTC : 🔄 @ 20:03:45UTC : ✅ Workflow completed successfully. |
zfan3-sc
approved these changes
Aug 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This got brought up in #273 (comment) -- I was unaware of
clamp(or that it worked like this!) so let's fix this elsewhere :)This fixes an issue where we could potentially see nodes get removed if their count mod 255 = 0, but clamp fixes this, see:
Thanks @svij-sc !