Skip to content

Enable adding labels to VAI pipelines#300

Merged
kmontemayor2-sc merged 9 commits intomainfrom
kmonte/add-vai-pl-labels
Aug 29, 2025
Merged

Enable adding labels to VAI pipelines#300
kmontemayor2-sc merged 9 commits intomainfrom
kmonte/add-vai-pl-labels

Conversation

@kmontemayor2-sc
Copy link
Copy Markdown
Collaborator

@kmontemayor2-sc kmontemayor2-sc commented Aug 27, 2025

Scope of work done

Recently we've been having lots of pipeline runs at different commits - and since the uploaded pipeline yaml is not visible from VAI ui, we should add tags for commit/etc.

This change lets us add ~arbitrary tags to new pipeline runs, enabling tagging with commit/version/etc.

Tested this and it works see
image

Did you add automated tests or write a test plan?

Added tests

Updated Changelog.md? YES

Ready for code review?: YES

@kmontemayor2-sc
Copy link
Copy Markdown
Collaborator Author

/e2e_test

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 27, 2025

GiGL Automation

@ 17:15:01UTC : 🔄 E2E Test started.

@ 18:28:23UTC : ❌ Workflow failed.
Please check the logs for more details.

@kmontemayor2-sc
Copy link
Copy Markdown
Collaborator Author

/e2e_test

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 27, 2025

GiGL Automation

@ 20:47:31UTC : 🔄 E2E Test started.

@ 21:50:53UTC : ❌ Workflow failed.
Please check the logs for more details.

@kmontemayor2-sc kmontemayor2-sc changed the title Kmonte/add vai pl labels Enable adding labels to VAI pipelines Aug 27, 2025
@kmontemayor2-sc
Copy link
Copy Markdown
Collaborator Author

/e2e_test

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 27, 2025

GiGL Automation

@ 22:06:20UTC : 🔄 E2E Test started.

@ 23:24:04UTC : ✅ Workflow completed successfully.

Comment thread Makefile Outdated
Copy link
Copy Markdown
Collaborator

@svij-sc svij-sc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we be clear i.e. through naming that these labels are only attached to VAI pipelines unlike the resource_labels ?

  1. map<string, string> resource_labels = 1;
  2. def get_resource_labels(
    self,
    component: Optional[GiGLComponents] = None,
    replacement_key: str = "COMPONENT",
    ) -> dict[str, str]:
    """
    Returns a dictionary of resource labels that can be used to tag resources in GCP.
    Users may also provide a custom suffix to replace in the resource labels which defaults to "COMPONENT".
    For example: If the resource labels are {"key": "value_COMPONENT"}, and the component is "DataPreprocessor",
    the returned resource labels will be {"key": "value_pre"}.
    Args:
    component (Optional[GiGLComponents]): The component to replace in the resource labels.
    replacement_key (str): The key to replace in the resource labels.
    Returns:
    dict[str, str]: The resource labels with the component replaced by the shortened cost label.
    """
    labels = dict(self.shared_resource_config.resource_labels)

Comment thread Makefile Outdated
@kmontemayor2-sc
Copy link
Copy Markdown
Collaborator Author

Should we be clear i.e. through naming that these labels are only attached to VAI pipelines unlike the resource_labels ?

Sure, added a note and renamed to run_labels

Copy link
Copy Markdown
Collaborator

@svij-sc svij-sc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ty for addressing comments - LGTM, one minor qq.

Comment thread Makefile
@kmontemayor2-sc kmontemayor2-sc marked this pull request as ready for review August 29, 2025 20:10
@kmontemayor2-sc kmontemayor2-sc added this pull request to the merge queue Aug 29, 2025
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Aug 29, 2025
@kmontemayor2-sc kmontemayor2-sc added this pull request to the merge queue Aug 29, 2025
Merged via the queue into main with commit 73b1a5a Aug 29, 2025
5 checks passed
@kmontemayor2-sc kmontemayor2-sc deleted the kmonte/add-vai-pl-labels branch August 29, 2025 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants