Enable adding labels to VAI pipelines#300
Conversation
|
/e2e_test |
GiGL Automation@ 17:15:01UTC : 🔄 @ 18:28:23UTC : ❌ Workflow failed. |
|
/e2e_test |
GiGL Automation@ 20:47:31UTC : 🔄 @ 21:50:53UTC : ❌ Workflow failed. |
|
/e2e_test |
GiGL Automation@ 22:06:20UTC : 🔄 @ 23:24:04UTC : ✅ Workflow completed successfully. |
svij-sc
left a comment
There was a problem hiding this comment.
Should we be clear i.e. through naming that these labels are only attached to VAI pipelines unlike the resource_labels ?
GiGL/python/gigl/src/common/types/pb_wrappers/gigl_resource_config.py
Lines 113 to 131 in ef23e02
Sure, added a note and renamed to |
svij-sc
left a comment
There was a problem hiding this comment.
Ty for addressing comments - LGTM, one minor qq.
Scope of work done
Recently we've been having lots of pipeline runs at different commits - and since the uploaded pipeline yaml is not visible from VAI ui, we should add tags for commit/etc.
This change lets us add ~arbitrary tags to new pipeline runs, enabling tagging with commit/version/etc.
Tested this and it works see

Did you add automated tests or write a test plan?
Added tests
Updated Changelog.md? YES
Ready for code review?: YES