Merged
Conversation
Collaborator
Author
|
/unit_test |
Contributor
GiGL Automation@ 23:26:54UTC : 🔄 @ 24:07:10UTC : ✅ Workflow completed successfully. |
mkolodner-sc
changed the base branch from
main
to
mkolodner-sc/handle_partition_edge_none
Collaborator
Author
|
/unit_test |
Contributor
GiGL Automation@ 20:12:48UTC : 🔄 @ 20:51:39UTC : ✅ Workflow completed successfully. |
…r-sc/cleanup_dataset_build
Base automatically changed from
mkolodner-sc/handle_partition_edge_none
to
main
September 22, 2025 22:00
kmontemayor2-sc
approved these changes
Sep 23, 2025
yliu2-sc
approved these changes
Sep 24, 2025
mkolodner-sc
requested review from
nshah-sc,
svij-sc,
xgao4-sc and
zfan3-sc
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope of work done
Our dataset.build() function has greatly grown in complexity and is now several hundreds of lines long. We should aim to shorten this so that our code is cleaner and more readable
Where is the documentation for this feature?: N/A
Did you add automated tests or write a test plan?
Updated Changelog.md? NO
Ready for code review?: NO