Skip to content

Throw error in partitioner for re-registering#325

Merged
swong3-sc merged 6 commits intomainfrom
swong3/elim_partition_re_register
Sep 15, 2025
Merged

Throw error in partitioner for re-registering#325
swong3-sc merged 6 commits intomainfrom
swong3/elim_partition_re_register

Conversation

@swong3-sc
Copy link
Copy Markdown
Collaborator

@swong3-sc swong3-sc commented Sep 12, 2025 •
edited
Loading

Scope of work done

Added error checks when re-registering node ids and features, edge indices and features, and labels

Where is the documentation for this feature?: N/A

Did you add automated tests or write a test plan?

Yes, added unit tests for all 5 registration methods.

Updated Changelog.md? NO

Ready for code review?: Yes

@swong3-sc
Copy link
Copy Markdown
Collaborator Author

swong3-sc commented Sep 12, 2025

/unit_test

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 12, 2025 •
edited
Loading

GiGL Automation

@ 22:18:10UTC : 🔄 Unit Test started.

@ 23:00:23UTC : ✅ Workflow completed successfully.

kmontemayor2-sc
kmontemayor2-sc reviewed Sep 12, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@kmontemayor2-sc kmontemayor2-sc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Sam!

Comment thread python/gigl/distributed/dist_partitioner.py Outdated
Comment thread python/gigl/distributed/dist_partitioner.py
Comment thread python/tests/unit/distributed/distributed_partitioner_test.py Outdated
Comment thread python/tests/unit/distributed/distributed_partitioner_test.py Outdated
mkolodner-sc
mkolodner-sc approved these changes Sep 15, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@mkolodner-sc mkolodner-sc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot Sam! This LGTM once we add the check/test for register_node_labels as well, thanks!

kmontemayor2-sc
kmontemayor2-sc approved these changes Sep 15, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@kmontemayor2-sc kmontemayor2-sc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Sam!

@swong3-sc swong3-sc added this pull request to the merge queue Sep 15, 2025
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Sep 15, 2025
@swong3-sc
Copy link
Copy Markdown
Collaborator Author

swong3-sc commented Sep 15, 2025

/help

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 15, 2025

GiGL Automation

@ 20:32:42UTC :

🤖 Available PR Commands

You can trigger the following workflows by commenting on this PR:

  • /help - Checkout code
  • /unit_test - Run Unit Tests
  • /integration_test - Run Integration Tests
  • /e2e_test - Run E2E Tests
  • /notebook_tests - Run Example Notebooks Tests
  • /lint_test - Run Linting Tests

💡 Usage: Simply comment on this PR with any of the commands above (e.g., /unit_test)

⏱️ Note: Commands may take some time to complete. Progress updates will be posted as comments.

@swong3-sc
Copy link
Copy Markdown
Collaborator Author

swong3-sc commented Sep 15, 2025

/unit_test

@swong3-sc
Copy link
Copy Markdown
Collaborator Author

swong3-sc commented Sep 15, 2025

/integration_test

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 15, 2025 •
edited
Loading

GiGL Automation

@ 20:33:12UTC : 🔄 Unit Test started.

@ 21:15:48UTC : ✅ Workflow completed successfully.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 15, 2025 •
edited
Loading

GiGL Automation

@ 20:33:23UTC : 🔄 Integration Test started.

@ 21:27:01UTC : ✅ Workflow completed successfully.

@swong3-sc
Copy link
Copy Markdown
Collaborator Author

swong3-sc commented Sep 15, 2025

/e2e_test

@swong3-sc
Copy link
Copy Markdown
Collaborator Author

swong3-sc commented Sep 15, 2025

/lint_test

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 15, 2025 •
edited
Loading

GiGL Automation

@ 20:33:39UTC : 🔄 E2E Test started.

@ 21:39:41UTC : ✅ Workflow completed successfully.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 15, 2025 •
edited
Loading

GiGL Automation

@ 20:33:48UTC : 🔄 Lint Test started.

@ 20:40:53UTC : ❌ Workflow failed.
Please check the logs for more details.

@swong3-sc swong3-sc added this pull request to the merge queue Sep 15, 2025
@swong3-sc
Copy link
Copy Markdown
Collaborator Author

swong3-sc commented Sep 15, 2025

/lint_test

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 15, 2025 •
edited
Loading

GiGL Automation

@ 21:48:58UTC : 🔄 Lint Test started.

@ 21:59:56UTC : ✅ Workflow completed successfully.

Merged via the queue into main with commit 3a12684 Sep 15, 2025
4 checks passed
@swong3-sc swong3-sc deleted the swong3/elim_partition_re_register branch September 15, 2025 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mkolodner-sc mkolodner-sc mkolodner-sc approved these changes

@kmontemayor2-sc kmontemayor2-sc kmontemayor2-sc approved these changes

@svij-sc svij-sc Awaiting requested review from svij-sc svij-sc is a code owner

@nshah-sc nshah-sc Awaiting requested review from nshah-sc nshah-sc is a code owner

@yliu2-sc yliu2-sc Awaiting requested review from yliu2-sc yliu2-sc is a code owner

@xgao4-sc xgao4-sc Awaiting requested review from xgao4-sc xgao4-sc is a code owner

@zfan3-sc zfan3-sc Awaiting requested review from zfan3-sc zfan3-sc is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@swong3-sc @mkolodner-sc @kmontemayor2-sc