shutdown example inference loaders#326
Merged
kmontemayor2-sc merged 2 commits intomainfrom Sep 15, 2025
Merged
Conversation
kmontemayor2-sc
requested review from
mkolodner-sc,
nshah-sc,
svij-sc,
xgao4-sc,
yliu2-sc and
zfan3-sc
as code owners
kmontemayor2-sc
commented
Sep 15, 2025
Collaborator
Author
kmontemayor2-sc
left a comment
kmontemayor2-sc
left a comment
There was a problem hiding this comment.
/e2e_test
Collaborator
Author
|
/e2e_test |
Collaborator
Author
|
/help |
Contributor
GiGL Automation@ 16:17:52UTC : 🔄 @ 17:43:03UTC : ✅ Workflow completed successfully. |
Contributor
GiGL Automation@ 16:18:07UTC : 🤖 Available PR CommandsYou can trigger the following workflows by commenting on this PR:
💡 Usage: Simply comment on this PR with any of the commands above (e.g., ⏱️ Note: Commands may take some time to complete. Progress updates will be posted as comments. |
zfan3-sc
approved these changes
Sep 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Doing this is the preferred way as calling del on the loaders does not always clean up all memory, leading to
part or all of the requested memory range is already mappederrors.