Set cuda devices for example loops#329
Merged
kmontemayor2-sc merged 1 commit intomainfrom Sep 19, 2025
Merged
Conversation
kmontemayor2-sc
requested review from
mkolodner-sc,
nshah-sc,
svij-sc,
xgao4-sc,
yliu2-sc and
zfan3-sc
as code owners
zfan3-sc
approved these changes
Sep 19, 2025
mkolodner-sc
approved these changes
Sep 19, 2025
Collaborator
mkolodner-sc
left a comment
mkolodner-sc
left a comment
There was a problem hiding this comment.
qq why haven't we been seeing this occur in our current E2E runs in GiGL?
Collaborator
Author
Not sure, maybe we need to use 4 devices instead of 2? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this, we could see issues with NCCL and devices failing.
As a follow up, we should consider renaming
get_available_devicetosetup_deviceand have it set the cuda device if applicable, but let's do the less invasive change first.