Add label_edge_type_to_message_passing_edge_type#333
Merged
kmontemayor2-sc merged 2 commits intomainfrom Sep 22, 2025
Merged
Conversation
kmontemayor2-sc
requested review from
mkolodner-sc,
nshah-sc,
svij-sc,
xgao4-sc,
yliu2-sc and
zfan3-sc
as code owners
mkolodner-sc
approved these changes
Sep 22, 2025
Collaborator
mkolodner-sc
left a comment
mkolodner-sc
left a comment
There was a problem hiding this comment.
This LGTM! Thanks Kyle!
yliu2-sc
approved these changes
Sep 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope of work done
Do this as a precursor to supporting multiple supervision edge types.
You can review this as a self-contained change (even if the end goal isn't obvious from here :P). Essentially this all goes to supporting https://github.com/Snapchat/GiGL/compare/kmonte/multipler-supervision-edges?expand=1#diff-f135690459bff031aa79fbf2b74e95ff2ed1f389b1f9c6d3fd7e8fe819a64e6bR20-R21
Where is the documentation for this feature?: N/A
Did you add automated tests or write a test plan?
Updated Changelog.md? NO
Ready for code review?: NO