Allow users to specify custom master nodes for networking utils#339
Merged
kmontemayor2-sc merged 3 commits intomainfrom Oct 1, 2025
Merged
Allow users to specify custom master nodes for networking utils#339kmontemayor2-sc merged 3 commits intomainfrom
kmontemayor2-sc merged 3 commits intomainfrom
Conversation
Collaborator
Author
|
/unit_test |
Contributor
GiGL Automation@ 18:35:57UTC : 🔄 @ 19:17:50UTC : ✅ Workflow completed successfully. |
svij-sc
reviewed
Sep 26, 2025
Collaborator
svij-sc
left a comment
svij-sc
left a comment
There was a problem hiding this comment.
btw, how are global ranks determined?
Collaborator
Author
For the server / client mode I was going to compute them before cluster launch and set them as env vars. But in practice it'll be [{storage cluster}. {compute cluster}] so storage master = 0, compute master = storage size |
svij-sc
approved these changes
Sep 30, 2025
Collaborator
svij-sc
left a comment
svij-sc
left a comment
There was a problem hiding this comment.
LGTM given comment is addressed.
kmontemayor2-sc
requested review from
mkolodner-sc,
nshah-sc,
xgao4-sc,
yliu2-sc and
zfan3-sc
as code owners
mkolodner-sc
approved these changes
Oct 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope of work done
We do this so in server/client mode we can have a "training" pg for both server and client, but have each server and client communicate with their respective leaders.
e.g for us to determine the ip/port on "training cluster leader" (global rank = 2).
Where is the documentation for this feature?: N/A
Did you add automated tests or write a test plan?
Updated Changelog.md? NO
Ready for code review?: NO