Add longer timeout to v1 trainer#348
Merged
kmontemayor2-sc merged 2 commits intomainfrom Sep 30, 2025
Merged
Conversation
Collaborator
Author
|
/unit_test |
Contributor
GiGL Automation@ 18:48:14UTC : 🔄 @ 19:37:37UTC : ✅ Workflow completed successfully. |
Collaborator
Author
|
/integration_test |
Collaborator
Author
|
/e2e_test |
Contributor
GiGL Automation@ 18:48:32UTC : 🔄 @ 19:38:41UTC : ✅ Workflow completed successfully. |
Contributor
GiGL Automation@ 18:48:44UTC : 🔄 @ 20:07:09UTC : ✅ Workflow completed successfully. |
yliu2-sc
reviewed
Sep 30, 2025
yliu2-sc
approved these changes
Sep 30, 2025
nshah-sc
approved these changes
Sep 30, 2025
kmontemayor2-sc
requested review from
mkolodner-sc,
svij-sc,
xgao4-sc and
zfan3-sc
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope of work done
Vertex AI may start the training jobs in a scattered manner, e.g. rank 0 starts at time 0, rank 10 starts at time 11, and so rank 0 timesout and crashes.
We should probably parameterize this in the future but in practice the 45 minute timeout is sufficient here.
Where is the documentation for this feature?: N/A
Did you add automated tests or write a test plan?
Tested internally succsefully.
Updated Changelog.md? NO
Ready for code review?: NO