Skip to content

migrate gigl.module -> gigl.nn#359

Merged
kmontemayor2-sc merged 5 commits intomainfrom
kmonte/module-to-nn
Nov 4, 2025
Merged

migrate gigl.module -> gigl.nn#359
kmontemayor2-sc merged 5 commits intomainfrom
kmonte/module-to-nn

Conversation

@kmontemayor2-sc
Copy link
Copy Markdown
Collaborator

Scope of work done

Per offline discussion, let's do this to better align with torch/pyg.

Where is the documentation for this feature?: N/A

Did you add automated tests or write a test plan?

Updated Changelog.md? NO

Ready for code review?: NO

@kmontemayor2-sc
Copy link
Copy Markdown
Collaborator Author

/e2e_test

@kmontemayor2-sc
Copy link
Copy Markdown
Collaborator Author

/unit_test

@kmontemayor2-sc
Copy link
Copy Markdown
Collaborator Author

/integration_test

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 9, 2025

GiGL Automation

@ 18:55:04UTC : 🔄 E2E Test started.

@ 20:25:23UTC : ❌ Workflow failed.
Please check the logs for more details.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 9, 2025

GiGL Automation

@ 18:55:06UTC : 🔄 Unit Test started.

@ 19:48:13UTC : ✅ Workflow completed successfully.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 9, 2025

GiGL Automation

@ 18:55:11UTC : 🔄 Integration Test started.

@ 19:46:30UTC : ✅ Workflow completed successfully.

Copy link
Copy Markdown
Collaborator

@mkolodner-sc mkolodner-sc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to update our internal uses of this import path as well -- thanks for the work!

@kmontemayor2-sc
Copy link
Copy Markdown
Collaborator Author

/e2e_test

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 9, 2025

GiGL Automation

@ 20:32:23UTC : 🔄 E2E Test started.

@ 21:46:50UTC : ✅ Workflow completed successfully.

Comment thread python/gigl/module/loss.py
Comment thread python/gigl/module/__init_.py Outdated
Comment thread python/gigl/nn/__init__.py
Copy link
Copy Markdown
Collaborator

@svij-sc svij-sc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM given the deprecation log is added

@kmontemayor2-sc kmontemayor2-sc marked this pull request as ready for review November 4, 2025 21:36
@kmontemayor2-sc kmontemayor2-sc added this pull request to the merge queue Nov 4, 2025
Merged via the queue into main with commit 8d7560b Nov 4, 2025
4 checks passed
@kmontemayor2-sc kmontemayor2-sc deleted the kmonte/module-to-nn branch November 4, 2025 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants