Skip to content

Properly set VAI env vars#373

Merged
kmontemayor2-sc merged 6 commits intomainfrom
kmonte/vai-env-vars
Nov 5, 2025
Merged

Properly set VAI env vars#373
kmontemayor2-sc merged 6 commits intomainfrom
kmonte/vai-env-vars

Conversation

@kmontemayor2-sc
Copy link
Copy Markdown
Collaborator

Scope of work done

Previously we weren't setting the env vars from the job config at all, let's fix that.

This is a perquisite fix to some of the server/client work I'm doing :)

Where is the documentation for this feature?: N/A

Did you add automated tests or write a test plan?

Updated Changelog.md? NO

Ready for code review?: NO

Copy link
Copy Markdown
Collaborator

@yliu2-sc yliu2-sc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kmontemayor2-sc kmontemayor2-sc marked this pull request as ready for review November 5, 2025 17:42
@kmontemayor2-sc kmontemayor2-sc added this pull request to the merge queue Nov 5, 2025
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Nov 5, 2025
@kmontemayor2-sc kmontemayor2-sc added this pull request to the merge queue Nov 5, 2025
@kmontemayor2-sc kmontemayor2-sc removed this pull request from the merge queue due to a manual request Nov 5, 2025
@kmontemayor2-sc kmontemayor2-sc added this pull request to the merge queue Nov 5, 2025
Merged via the queue into main with commit 07fef45 Nov 5, 2025
4 checks passed
@kmontemayor2-sc kmontemayor2-sc deleted the kmonte/vai-env-vars branch November 5, 2025 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants