Add create_test_process_group and swap Loader tests away from DistContext#376
Merged
kmontemayor2-sc merged 6 commits intomainfrom Nov 19, 2025
Merged
Add create_test_process_group and swap Loader tests away from DistContext#376kmontemayor2-sc merged 6 commits intomainfrom
create_test_process_group and swap Loader tests away from DistContext#376kmontemayor2-sc merged 6 commits intomainfrom
Conversation
Collaborator
Author
|
/unit_test |
Contributor
GiGL Automation@ 23:16:12UTC : 🔄 @ 24:25:36UTC : ✅ Workflow completed successfully. |
Collaborator
Author
|
/unit_test |
Contributor
GiGL Automation@ 23:17:21UTC : 🔄 @ 24:22:06UTC : ✅ Workflow completed successfully. |
kmontemayor2-sc
changed the title
Collaborator
Author
|
/unit_test |
Contributor
GiGL Automation@ 01:09:33UTC : 🔄 @ 02:25:38UTC : ✅ Workflow completed successfully. |
mkolodner-sc
reviewed
Nov 7, 2025
kmontemayor2-sc
changed the title
create_test_process_group and swap Loader tests away from DistContext
mkolodner-sc
approved these changes
Nov 17, 2025
Collaborator
mkolodner-sc
left a comment
mkolodner-sc
left a comment
There was a problem hiding this comment.
LGTM provided tests pass, thanks Kyle!
Collaborator
Author
|
/unit_test |
Collaborator
Author
|
/integration_test |
Contributor
GiGL Automation@ 19:25:32UTC : 🔄 @ 20:30:48UTC : ✅ Workflow completed successfully. |
Contributor
GiGL Automation@ 19:25:42UTC : 🔄 @ 20:42:33UTC : ✅ Workflow completed successfully. |
yliu2-sc
approved these changes
Nov 18, 2025
kmontemayor2-sc
requested review from
nshah-sc,
svij-sc,
xgao4-sc and
zfan3-sc
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope of work done
I was hoping this would save more time but it seems like it's just a few minutes, sadly...
Guess I should properly benchmark :P
Anyways this should save time and logspam regardless?
Where is the documentation for this feature?: N/A
Did you add automated tests or write a test plan?
Updated Changelog.md? NO
Ready for code review?: NO