Add compute_cluster_local_world_size to VertexAiGraphStoreConfig and GraphStoreInfo#380
Merged
kmontemayor2-sc merged 4 commits intomainfrom Nov 17, 2025
Merged
Conversation
Collaborator
Author
|
/unit_test |
Collaborator
Author
|
/integration_test |
Contributor
GiGL Automation@ 24:26:02UTC : 🔄 @ 01:32:01UTC : ✅ Workflow completed successfully. |
Contributor
GiGL Automation@ 24:26:09UTC : 🔄 @ 01:44:10UTC : ✅ Workflow completed successfully. |
svij-sc
reviewed
Nov 14, 2025
svij-sc
approved these changes
Nov 14, 2025
kmontemayor2-sc
changed the title
num_processes_per_compute to VertexAiGraphStoreConfig and GraphStoreInfocompute_cluster_local_world_size to VertexAiGraphStoreConfig and GraphStoreInfo
mkolodner-sc
approved these changes
Nov 17, 2025
kmontemayor2-sc
requested review from
nshah-sc,
xgao4-sc,
yliu2-sc and
zfan3-sc
as code owners
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope of work done
We need to expose this somehow in our code, I am planning on updating our VAI service job launch code to set the env variable in a subsequent PR.
We need this as we need "number clients" which is client machines x "processes / client machine" when setting up server code glt server/client mode.
I want to put this in the config as I feel like it's more centralized and we require the config anyways to launch graph store jobs.
The alternative here is to have some cross/cluster information sharing with torch rpc but I feel like that's more involved, especially as we are going to control the server main (for now).
Where is the documentation for this feature?: N/A
Did you add automated tests or write a test plan?
Updated Changelog.md? NO
Ready for code review?: NO