Update resource config wrapper / validation check to support graph store mode

[kmontemayor2-sc]

Scope of work done

As mentioned, support VertexAIGraphStore config message in our wrapper and validation check now.

Also slop-up some tests ;)

Where is the documentation for this feature?: N/A

Did you add automated tests or write a test plan?

Updated Changelog.md? NO

Ready for code review?: NO

[svij-sc]

Some comments.

Generally I am conflicted to see the value of adding all these tests. A lot of these tests are essentially testing asserts that an object is correctly housing another object it was initialized with.

If anything, there may be more value in testing the config validator raising issues when configs are not correctly formulated - which is higher order and will implicitly capture most tests here.

[svij-sc]

I would prefer that we dont add new* tests to test supposedly deprecated code.

Also, unsure if you had a chance to look at #383 (review) yet.
Nonetheless, approving since overall quality is still improving here for our testing suite.
Thanks for the work!

[kmontemayor2-sc]

Generally I am conflicted to see the value of adding all these tests. A lot of these tests are essentially testing asserts that an object is correctly housing another object it was initialized with.

I think that there is actually non-trivial logic in the wrapper, see trainer_config, get_resource_labels, and shared_resource_config, and that is worth testing.

As for testing the pass through stuff, agreed it's less useful but I don't think it hurts - it may catch a reggression in the future and ime these sorts of unit tests are not that costly to maintain. And if they are costly, we can always delete them :P

If anything, there may be more value in testing the config validator raising issues when configs are not correctly formulated - which is higher order and will implicitly capture most tests here.

We do this in this PR, too!

[svij-sc]

I think that there is actually non-trivial logic in the wrapper, see trainer_config, get_resource_labels, and shared_resource_config, and that is worth testing.

Totally, this part re: labels, et al is probably worth it. But others are just asserting what I mentioned prior

[mkolodner-sc]

Thanks Kyle! Did a pass

[mkolodner-sc]

Thanks Kyle!