Remove GLT imports from our example code#389
Merged
kmontemayor2-sc merged 2 commits intomainfrom Nov 19, 2025
Merged
Conversation
kmontemayor2-sc
requested review from
mkolodner-sc,
nshah-sc,
svij-sc,
xgao4-sc,
yliu2-sc and
zfan3-sc
as code owners
Collaborator
Author
|
/e2e_test |
Contributor
GiGL Automation@ 17:55:20UTC : 🔄 @ 19:17:40UTC : ✅ Workflow completed successfully. |
Collaborator
Author
|
/e2e_test |
Contributor
GiGL Automation@ 18:02:54UTC : 🔄 @ 19:21:04UTC : ✅ Workflow completed successfully. |
kmontemayor2-sc
changed the title
mkolodner-sc
approved these changes
Nov 19, 2025
Collaborator
mkolodner-sc
left a comment
mkolodner-sc
left a comment
There was a problem hiding this comment.
Thanks Kyle! LGTM provided tests pass
One callout is we also probably should remove the GLT distributed rpc calls here:
but that can likely be done as a follow-up (I was going to do this at some point this quarter). Thanks for the work!
Collaborator
Author
Yeah that's probably a separate change :) |
nshah-sc
approved these changes
Nov 19, 2025
Collaborator
nshah-sc
left a comment
nshah-sc
left a comment
There was a problem hiding this comment.
LGTM provided this is confirmed to not impact functionality.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope of work done
We should avoid having public usages of the GLT apis as much as possible.
Swapping away from the usages in our examples.
See some job logs
inference which are still fine.
Where is the documentation for this feature?: N/A
Did you add automated tests or write a test plan?
Updated Changelog.md? NO
Ready for code review?: NO