OSS Initial Release#4
Merged
Merged
Conversation
Co-authored-by: Shubham Vij <svij@snapchat.com> Co-authored-by: Shubham Vij <reachme@shubhamvij.com> Co-authored-by: Neil Shah <nshah@snapchat.com> Co-authored-by: Neil Shah <nshah171@gmail.com> Co-authored-by: Yozen Liu <yliu2@snapchat.com> Co-authored-by: Yozen Liu <yliu886@yahoo.com> Co-authored-by: Kyle Montemayor <kmontemayor2@snapchat.com> Co-authored-by: Kyle Montemayor <kyle.e.montemayor@gmail.com> Co-authored-by: Matt Kolodner <mkolodner@snapchat.com> Co-authored-by: Matt Kolodner <matt.kolodner@gmail.com> Co-authored-by: Tong Zhao <tzhao@snapchat.com> Co-authored-by: Tong Zhao <tong@tzhao.io> Co-authored-by: Zihao Fan <zfan3@snapchat.com> Co-authored-by: Zihao Fan <fanzihao.thu@gmail.com> Co-authored-by: Xiaobin Gao <xgao4@snapchat.com> Co-authored-by: Elham Ghazizadeh <eghazizadeh@snapchat.com> Co-authored-by: Asket Agarwal <aagarwal5@snapchat.com> Co-authored-by: Ankit Batra <abatra2@snapchat.com>
svij-sc
requested review from
kmontemayor2-sc,
mkolodner-sc,
nshah-sc and
yliu2-sc
as code owners
Collaborator
Author
|
/unit_test |
Contributor
GiGL Automation@ 21:13:38UTC : 🔄 @ 21:32:18UTC : ✅ Workflow completed successfully. |
kmontemayor2-sc
approved these changes
Apr 24, 2025
Collaborator
kmontemayor2-sc
left a comment
kmontemayor2-sc
left a comment
There was a problem hiding this comment.
Thanks Shubham!
Collaborator
Author
|
/integration_test |
Collaborator
Author
|
/e2e_test |
Contributor
GiGL Automation@ 21:33:10UTC : 🔄 @ 22:12:33UTC : ✅ Workflow completed successfully. |
Contributor
GiGL Automation@ 21:33:23UTC : 🔄 @ 23:00:12UTC : ✅ Workflow completed successfully. |
Collaborator
Author
|
/lint_test |
Contributor
GiGL Automation@ 21:36:50UTC : 🔄 @ 21:46:14UTC : ✅ Workflow completed successfully. |
yliu2-sc
approved these changes
Apr 24, 2025
kmontemayor2-sc
pushed a commit
that referenced
this pull request
May 21, 2026
…, skip-blocks-descendants Three execution-correctness fixes from the Codex review (issues #2, #3, #4 — all High): 1. Clean-worktree preflight in Step 7. Before any `git checkout` in --execute mode, require `git status --short` to be empty. Tracked local edits can otherwise follow a checkout into the new decomposition branch and get staged or committed by mistake. Skill now stops and asks the user to stash / commit / discard before continuing. 2. Cherry-pick semantics: each PR's OWN commits, exactly once. The previous phrasing ("cherry-pick predecessor commits") was ambiguous and could be read as "cherry-pick the range `main..decomp/C`". That range includes C's own ancestors (e.g. shared root B), so picking it after already picking B directly causes B's commits to replay and conflict. The skill now says explicitly: cherry-pick each ancestor PR's OWN commits — never full branch ranges — in topological order. Shared ancestors (top of a diamond) get cherry-picked exactly once total per dependent branch. Updated: - Step 3 basic-build example to use `<PR_A's OWN commits>` and add a paragraph spelling out the rule. - Step 3 diamond paragraph: "each ancestor PR's own commits exactly once, in topological order." - Worked example F construction: per-line comments noting that C and D each contain B's commits but we don't re-include them. - Step 7 bash block to mirror the same convention. 3. Skipping a PR may block its descendants. Per user clarification: skipping a parent PR defers the entire subtree rooted at that PR. Descendants can't be merged either — their cherry-picked copy of the predecessor's code is unreviewed at HEAD until the predecessor lands. Only independent siblings remain unblocked. Skill now explicitly tells the user "Skipping #N defers #M and #K (its dependents) too." Also added three Common Mistakes entries covering each of the above so the rules survive deadline-pressure rationalization. mdformat clean. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Releasing code for active OSS development.
Will point public over from https://github.com/snap-research/GiGL to here soon