Introduce bq util to get latest table name given prefix.#516
Merged
Conversation
Collaborator
Author
|
/unit_test |
Contributor
GiGL Automation@ 19:37:29UTC : 🔄 @ 19:43:51UTC : ❌ Workflow failed. |
Contributor
GiGL Automation@ 19:37:30UTC : 🔄 @ 19:45:04UTC : ✅ Workflow completed successfully. |
Collaborator
|
Also let's fix the unit tests? |
kmontemayor2-sc
approved these changes
Feb 26, 2026
yliu2-sc
approved these changes
Feb 26, 2026
Comment on lines
+332
to
+333
| if len(table_path) != expected_table_path_len: | ||
| continue |
Collaborator
There was a problem hiding this comment.
fyi I'm pretty sure this logic is different from before, where we would throw 1 if there was a non-matching table. I don't have a strong preference here just curious about the change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope of work done
Introducing functionality to get latest table name given prefix for a datetime suffixed table.
We are duplicating this functionality in downstream use cases - figured i'd intro a utility.