Expose gigl vars as env vars for the custom luancher#642
Conversation
There was a problem hiding this comment.
Might be good opportunity to also consolidate existing VAI launchers to use env vars too instead of injected runtime args:
GiGL/gigl/src/common/vertex_ai_launcher.py
Lines 256 to 264 in 454b54b
Adopting one distinct pattern will make it easier for us to maintain the different code paths, and I am happy to adapt the env variables given prior discussed arguments as the golden path, but lets also old our old injection paths in existing launchers.
svij-sc
left a comment
There was a problem hiding this comment.
I'd prefer to have this PR in first as the other changes may be somewhat complicated still (and I'm not sure we need all of these things to be exposed globally)
Approving conditionally - only for the purposes of unblocking. I am hoping we do a fast follow up here to address concerns outlined below:
Do this so custom launchers can get the task config, etc.
The alternative approach here is that we can use omegaconf but as we discussed offline that may be more complicated as the resolution would change often.