Skip to content

Pass resource config URI to graph store networking integration test workers#666

Merged
kmontemayor2-sc merged 3 commits into
mainfrom
kmonte/fix-networking-test
Jun 3, 2026
Merged

Pass resource config URI to graph store networking integration test workers#666
kmontemayor2-sc merged 3 commits into
mainfrom
kmonte/fix-networking-test

Conversation

@kmontemayor2-sc
Copy link
Copy Markdown
Collaborator

get_graph_store_info() reads get_resource_config() to build the readiness URI (added in #533), but the launched Vertex AI workers had no GIGL_RESOURCE_CONFIG_URI in their env, so they failed with "No resource config provided". Inject it via the compute pool's environment_variables, which launch_graph_store_job propagates to both compute and storage pools.

Scope of work done

Where is the documentation for this feature?: N/A

Did you add automated tests or write a test plan?

Updated Changelog.md? NO

Ready for code review?: NO

…orkers

get_graph_store_info() reads get_resource_config() to build the readiness
URI (added in #533), but the launched Vertex AI workers had no
GIGL_RESOURCE_CONFIG_URI in their env, so they failed with "No resource
config provided". Inject it via the compute pool's environment_variables,
which launch_graph_store_job propagates to both compute and storage pools.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@kmontemayor2-sc
Copy link
Copy Markdown
Collaborator Author

/all_test

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 2, 2026

GiGL Automation

@ 23:38:48UTC : 🔄 Python Unit Test started.

@ 24:39:40UTC : ✅ Workflow completed successfully.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 2, 2026

GiGL Automation

@ 23:38:49UTC : 🔄 Scala Unit Test started.

@ 23:49:04UTC : ✅ Workflow completed successfully.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 2, 2026

GiGL Automation

@ 23:38:51UTC : 🔄 Lint Test started.

@ 23:46:33UTC : ✅ Workflow completed successfully.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 2, 2026

GiGL Automation

@ 23:38:51UTC : 🔄 E2E Test started.

@ 01:39:03UTC : ✅ Workflow completed successfully.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 2, 2026

GiGL Automation

@ 23:38:51UTC : 🔄 C++ Unit Test started.

@ 23:40:42UTC : ✅ Workflow completed successfully.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 2, 2026

GiGL Automation

@ 23:38:52UTC : 🔄 Integration Test started.

@ 24:54:24UTC : ✅ Workflow completed successfully.

…test workers

The test runner's resource config URI may be a local path that does not
exist on the worker Docker image, so passing it directly to the workers via
GIGL_RESOURCE_CONFIG_URI would not be readable. Instead, upload the
in-memory resource config to the regional bucket (accessible to workers over
GCS), pass that URI to the workers, and delete it in tearDown.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@kmontemayor2-sc
Copy link
Copy Markdown
Collaborator Author

/all_test

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 2, 2026

GiGL Automation

@ 23:41:35UTC : 🔄 Python Unit Test started.

@ 24:43:57UTC : ✅ Workflow completed successfully.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 2, 2026

GiGL Automation

@ 23:41:36UTC : 🔄 Lint Test started.

@ 23:49:21UTC : ✅ Workflow completed successfully.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 2, 2026

GiGL Automation

@ 23:41:36UTC : 🔄 Integration Test started.

@ 24:58:02UTC : ✅ Workflow completed successfully.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 2, 2026

GiGL Automation

@ 23:41:37UTC : 🔄 E2E Test started.

@ 01:38:09UTC : ✅ Workflow completed successfully.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 2, 2026

GiGL Automation

@ 23:41:39UTC : 🔄 C++ Unit Test started.

@ 23:43:31UTC : ✅ Workflow completed successfully.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 2, 2026

GiGL Automation

@ 23:41:40UTC : 🔄 Scala Unit Test started.

@ 23:51:00UTC : ✅ Workflow completed successfully.

@kmontemayor2-sc kmontemayor2-sc mentioned this pull request Jun 3, 2026
Copy link
Copy Markdown
Collaborator

@mkolodner-sc mkolodner-sc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kmontemayor2-sc kmontemayor2-sc marked this pull request as ready for review June 3, 2026 20:45
@mkolodner-sc mkolodner-sc added this pull request to the merge queue Jun 3, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jun 3, 2026
@kmontemayor2-sc kmontemayor2-sc added this pull request to the merge queue Jun 3, 2026
Merged via the queue into main with commit 93782c6 Jun 3, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants