Skip to content

Fix: Add Fedora/RHEL support to Linux dev setup #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: Add Fedora/RHEL support to Linux dev setup #41

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 48 additions & 8 deletions npm_modules/cli/src/setup/linuxSetup.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,22 +6,62 @@ import { ANDROID_LINUX_COMMANDLINE_TOOLS } from './versions';

const BAZELISK_URL = 'https://github.com/bazelbuild/bazelisk/releases/download/v1.26.0/bazelisk-linux-amd64';

// Detect which package manager is available
function detectPackageManager(): 'apt' | 'dnf' | 'yum' {
if (checkCommandExists('apt-get')) {
return 'apt';
} else if (checkCommandExists('dnf')) {
return 'dnf';
} else if (checkCommandExists('yum')) {
return 'yum';
} else {
throw new Error('No supported package manager found. Please install apt-get, dnf, or yum.');
}
}

// Get the correct package names for each package manager
function getPackageNames(pm: 'apt' | 'dnf' | 'yum'): string[] {
const packages = {
apt: ['zlib1g-dev', 'git-lfs', 'watchman', 'libfontconfig-dev', 'adb'],
dnf: ['zlib-devel', 'git-lfs', 'watchman', 'fontconfig-devel', 'android-tools'],
yum: ['zlib-devel', 'git-lfs', 'watchman', 'fontconfig-devel', 'android-tools'],
};
return packages[pm];
}

export async function linuxSetup(): Promise<void> {
const devSetup = new DevSetupHelper();
const packageManager = detectPackageManager();
const packages = getPackageNames(packageManager);

await devSetup.runShell('Installing dependencies from apt', [
`sudo apt-get install zlib1g-dev git-lfs watchman libfontconfig-dev adb`,

// Install dependencies using the detected package manager
await devSetup.runShell(`Installing dependencies using ${packageManager}`, [
`sudo ${packageManager} install -y ${packages.join(' ')}`,
]);

await devSetup.runShell('Installing libtinfo5', [
`wget http://security.ubuntu.com/ubuntu/pool/universe/n/ncurses/libtinfo5_6.3-2ubuntu0.1_amd64.deb`,
`sudo apt install ./libtinfo5_6.3-2ubuntu0.1_amd64.deb`,
]);
// libtinfo5 installation - only for apt-based systems
if (packageManager === 'apt') {
await devSetup.runShell('Installing libtinfo5', [
`wget http://security.ubuntu.com/ubuntu/pool/universe/n/ncurses/libtinfo5_6.3-2ubuntu0.1_amd64.deb`,
`sudo apt install ./libtinfo5_6.3-2ubuntu0.1_amd64.deb`,
]);
} else {
// For Fedora/RHEL, ncurses-compat-libs provides libtinfo5
await devSetup.runShell('Installing ncurses compatibility libraries', [
`sudo ${packageManager} install -y ncurses-compat-libs`,
]);
}

// Install Java if not present
if (!checkCommandExists('java')) {
await devSetup.runShell('Installing Java Runtime Environment', ['sudo apt install default-jre']);
const javaPackage = packageManager === 'apt' ? 'default-jre' : 'java-latest-openjdk';
await devSetup.runShell('Installing Java Runtime Environment', [
`sudo ${packageManager} install -y ${javaPackage}`,
]);
}

// Install Bazelisk
const bazeliskPathSuffix = '.valdi/bin/bazelisk';
const bazeliskTargetPath = path.join(HOME_DIR, bazeliskPathSuffix);
await devSetup.downloadToPath(BAZELISK_URL, bazeliskTargetPath);
Expand All @@ -35,4 +75,4 @@ export async function linuxSetup(): Promise<void> {
await devSetup.setupAndroidSDK(ANDROID_LINUX_COMMANDLINE_TOOLS);

devSetup.onComplete();
}
}