Merged
Conversation
Contributor
twoimo
commented
Dec 19, 2024
twoimo
commented
- Updated fish name display logic to show detected fish label or '�� �� ����' if undetectable.
- Added conditional rendering for multiple detection candidates with confidence levels.
- Introduced a new method to determine confidence color based on detection confidence.
- Improved user feedback by clearly indicating detection results and confidence levels.
Integrate fishing place information and enhance database features
Refactor confidence display and input handling in Catches and Home views
Fix mulddae widget timezone into korea
Enhance database features and fix timezone handling for mulddae widget
…ted fishing dates and enhance detection handling - Modified `usage_fee` field description in `main.py`. - Added `PROHIBITED_DATES` dictionary to manage fishing restrictions based on species in `main.py`. - Updated prediction handling in `CameraActionSheet.vue` to check for prohibited dates and adjust routing accordingly. - Enhanced `FishResultWarning.vue` to display prohibited dates and improved layout for better user experience.
- Updated loading text from Korean to English in both FishResultNormal.vue and FishResultWarning.vue. - Enhanced AI detection result display in FishResultNormal.vue with a new layout and added fish details (name, scientific name, description). - Introduced computed property for fishName in FishResultNormal.vue to dynamically display detected fish label. - Added additional buttons for sharing results and navigating to caught fish list in FishResultWarning.vue for better user interaction.
- Added image popup modal for displaying enlarged images. - Implemented share modal with options to share results via Facebook, Twitter, and copy link. - Updated Vuex store usage for reactivity. - Improved image loading handling and error messaging. - Introduced functions for opening image popup and navigating to catches page.
…nteraction - Updated image click handling in FishResultNormal.vue and FishResultWarning.vue to use a dedicated method for better readability and error handling. - Enhanced image source computation to support authenticated and unauthenticated users. - Improved layout and styling for AI detection results and image display. - Added functionality to close image popups and handle image loading states more effectively. - Adjusted z-index values for header and modal components to ensure proper layering.
…d user experience
- Added loading state handling to buttons and modals in FishResultNormal.vue and FishResultWarning.vue to improve user experience during data processing. - Updated conditional rendering to prevent user interactions while loading, ensuring a smoother interface. - Improved layout and styling for AI detection results and user actions, enhancing overall usability.
…ction display in FishResult components - Corrected the success message in the signup function from '����' to '������'. - Updated error message in add_catch to specify that either image URL or detection results are required. - Improved image handling in FishResultNormal.vue and FishResultWarning.vue by adding bounding box display for detections. - Implemented image load event to capture dimensions for accurate bounding box rendering. - Enhanced layout for better user experience when displaying fish images and detection results.
…onfidence indication - Updated fish name display logic to show detected fish label or '�� �� ����' if undetectable. - Added conditional rendering for multiple detection candidates with confidence levels. - Introduced a new method to determine confidence color based on detection confidence. - Improved user feedback by clearly indicating detection results and confidence levels.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.