Limit laser power lookup to table size #219
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nivekmai
force-pushed
the
limit_laser_power
branch
4 times, most recently
from
0f1a27a to
afac282
Compare
Contributor
Author
|
One day I'll get this right... |
Summary: Credit to @brent113 for finding this originally. The issue is that we are allowed to call `ToolHeadLaser::SetPower` with any value, and it will attempt to do the conversion through the `power_table_` using that value. This means that calling `ToolHeadLaser::SetPower` with any value above 100 will result in reading random data and attempting to set that as the PWM value. To fix, we should clamp `power` to the size of the `power_table_` when doing any lookups. Test Plan: `pio run` I also wrote a test of sorts (http://tpcg.io/AMS3HP), but it'd be better if I could write a proper test for this method.
nivekmai
force-pushed
the
limit_laser_power
branch
from
afac282 to
6d020c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Credit to @brent113 for finding this originally.
The issue is that we are allowed to call
ToolHeadLaser::SetPowerwithany value, and it will attempt to do the conversion through the
power_table_using that value.This means that calling
ToolHeadLaser::SetPowerwith any value above100 will result in reading random data and attempting to set that as the
PWM value.
To fix, we should clamp
powerto the size of thepower_table_whendoing any lookups.
Test Plan:
pio runI also wrote a test of sorts (http://tpcg.io/AMS3HP), but it'd be better
if I could write a proper test for this method.