Conversation
…g DM
- Added proper null checks and error handling for user fetch failures
- Improved fallback notification logic when DM fails
- Added `collector.on("error", ...)` handlers to both reaction collectors
- Added `finally` blocks to ensure collectors are properly stopped
- Added debug logging for message deletion errors
- Created a centralized `MAP_CONFIG` object with configuration for surf, kz, and bhop maps
- Added `getMapType()` helper function to determine map type
- Consolidated `getWebsite()`, `getStatsPage()`, and `getMapImage()` functions to use the shared configuration
- Eliminated code duplication across all three functions
- Added null checks for guild and channel existence
- Added warning logs when guild or channel is not found
- Prevents crashes when commands are sent before bot is fully ready
- Created `validateMapName()` function with comprehensive validation
- Validates for empty input, mentions, invalid characters, and length limits
- Applied to both `follow` and `unfollow` commands
- No `var` declarations found in the codebase (already using `let`/`const`)
- Duplicate `messageCreate` event handler merged into single handler with routing
- Server refresh parallelized using `Promise.all()`
- `isEmpty` function fixed to use `Object.keys().length === 0`
- `keywordToServer` function fixed to return `null` instead of `false` and made async
- Database error logging added to all functions in db.js
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Actively working on refactor and modernization of the bot