Skip to content

Conversation

@Snider
Copy link
Owner

@Snider Snider commented Nov 13, 2025

This commit increases the test coverage of the Core package to over 88%.

  • Adds tests for ServiceStartup and ServiceShutdown methods in core.go.
  • Adds tests for App(), Config(), and Display() methods in core.go.
  • Adds a test for IsEnabled in interfaces.go.
  • Adds tests for NewServiceRuntime, Core(), and Config() in runtime.go.
  • Adds tests for NewWithFactories, ServiceName, ServiceStartup, and ServiceShutdown in runtime_pkg.go.
  • Removes the unused core/testutil directory.
  • Rewrites the TestNewWithFactories_Good test to correctly validate the original NewWithFactories function's behavior.

This commit increases the test coverage of the Core package to over 88%.

- Adds tests for `ServiceStartup` and `ServiceShutdown` methods in `core.go`.
- Adds tests for `App()`, `Config()`, and `Display()` methods in `core.go`.
- Adds a test for `IsEnabled` in `interfaces.go`.
- Adds tests for `NewServiceRuntime`, `Core()`, and `Config()` in `runtime.go`.
- Adds tests for `NewWithFactories`, `ServiceName`, `ServiceStartup`, and `ServiceShutdown` in `runtime_pkg.go`.
- Removes the unused `core/testutil` directory.
- Rewrites the `TestNewWithFactories_Good` test to correctly validate the original `NewWithFactories` function's behavior.
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 13, 2025

Warning

Rate limit exceeded

@Snider has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 15 minutes and 5 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 4133ead and a89f470.

📒 Files selected for processing (3)
  • core/testutil/testutil.go (0 hunks)
  • core_test.go (1 hunks)
  • runtime_pkg_test.go (1 hunks)
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch increase-test-coverage

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Nov 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@Snider Snider merged commit 2898ddf into dev Nov 13, 2025
5 checks passed
@Snider Snider deleted the increase-test-coverage branch November 13, 2025 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants