Skip to content

Add support for ValueType<T...> in the API #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Apr 26, 2018
Merged

Add support for ValueType<T...> in the API #73

merged 13 commits into from
Apr 26, 2018

Conversation

@KrzysFR
Copy link
Contributor

@KrzysFR KrzysFR commented Apr 25, 2018 •
edited
Loading

Add a reference to System.ValueTuple v4.4, and start exposing them in the core API, cf Issue #70

  • Interop with ITuple and Stuple<T...>
  • Supported by TuPack(...)
  • Supported by IKeySubspace implementations
  • Update internal API to use ValueTuple in preference of older types
  • Expose more overloads that take ValueTuples directly

KrzysFR added 4 commits April 25, 2018 18:10
@KrzysFR
Add reference to System.ValueTuples v4.4 and enable support for Value…
2677585 
…Tuples in the core tuple API
@KrzysFR
Add first-class support for ValueTuples with subspaces
61f3716 
- Add overloads that take ValueTuple<...> to most IKeySubspaces implementations
- Add quick indexers on typed keyspace that take either the items, or a value tuple
@KrzysFR
Use new indexer on TypedKeySubspace.Keys
cf764bd
@KrzysFR
Use Tuples instead of KeyValuePair in some places
0b7a53d
@KrzysFR KrzysFR mentioned this pull request Apr 25, 2018
Closed
KrzysFR added 9 commits April 26, 2018 11:33
@KrzysFR
Add more tuple usages
10855a8
@KrzysFR
Add a base IKeyEncoder interface that links encoders and Encoding
26b359a 
- Makes it easier to go back and forth between encoders and encoding
@KrzysFR
Add overloads to simplify creating and copying subspaces with specifi…
2bcbd45 
…c encodings

- Most 'encoding' arguments are optional and will default to TypeSystem.Tuples if null
- Copying existing subspaces will try to reuse the original encoding
@KrzysFR
Refactor the core Key Encoders and Tuple Packers to use ValueTuple
505d3ab 
- Added a lot of overloads that use ValueTuples natively
- Cleaned up some paths to TupleEncoder, and it will always require a prefix (can be empty)
@KrzysFR
Get rid of #if ENABLE_VALUETUPLES, ValueTuple support is now implicit
da5ace0
@KrzysFR
Use the literal tuple syntax everywhere possible
ce869dd
@KrzysFR
Replace some STuple uses with ValueTuple
da34f2a
@KrzysFR
fix or remove old xml comments
07fa586
@KrzysFR
Rename some KeySubspace.FromKey(..) into CreateDynamic(..) or CreateT…
a94de41 
…yped(..)
@KrzysFR
Copy link
Contributor Author

KrzysFR commented Apr 26, 2018

Included more changes to the core key and subspace API to better use tuples, and decouple them from the Tuple Encoding itself.

@KrzysFR KrzysFR merged commit f22e9ce into master Apr 26, 2018
@KrzysFR KrzysFR deleted the dev/valuetuples branch October 25, 2018 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@KrzysFR