-
Notifications
You must be signed in to change notification settings - Fork 27
support nip46 login #1504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
support nip46 login #1504
Conversation
|
@fiatjaf is attempting to deploy a commit to the snowcait's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Yes, this seems to work fine. Except I can't see the posts I just made using a new bunker. I can see them in other clients though, so seems to be a different issue. |
|
Hmm, yeah, when the bunker doesn't support nip04 things go bad. Could that be it? I tried with two bunkers, one supporting nip04_encrypt/decrypt, and it worked perfectly. The other didn't, so I could still write posts, but my own posts were not showing for me. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Thanks!
It might be NIP-42 AUTH. |
|
Oh, by the way, I've included this weird |
|
Yes, I'm still using the old SimplePool for logging and can't upgrade the version unless I switch to rx-nostr because the latest version of SimplePool can't output logs. |
| storage.set('nip46clientSecret', bytesToHex(ks)); | ||
| } | ||
|
|
||
| bunkerSigner = new BunkerSigner(ks, bp); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm testing with nsec.app, but I can't log in.
If I add await bunkerSigner.connect(); here, the first login is successful, but subsequent logins fail.
Do you know what's going on?
Bunker URL is bunker://***?relay=wss://relay.nsec.app&secret=***.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll try with nsec.app. I never try anything with it because every time I try to use it I get some weird browser-related problem, but maybe it is good now. Thank you for trying.
|
I fixed NIP-42 signer bug by #1505. |
|
I wish there was a way to schedule browser tabs to reappear after a while. I'll have to close this one now and because that doesn't exist I'll have to rely on my memory to open this again next week. Wish me luck. |
# Conflicts: # web/package.json # web/src/lib/Signer.ts # web/src/lib/stores/Author.ts
|
I updated nostr-tools to the latest version and merged it into this branch. |
|
One day everything will be fixed. |
Not very well tested yet, but seems to work. I'll leave this here just in case.
One thing that is puzzling me is that even though this works with NIP-46 Nostter still prompts me to authorize stuff from nos2x. Do you know if there is some other weird place where it could be calling that? It isn't happening in the
Signerobject.