Layer and Site comments#63
Merged
jomey merged 8 commits intoapi_upload_updatefrom Jul 7, 2025
Merged
Conversation
This is the first part of reworking how comments are handled. This covers the 'comments' column under the stratigraphy data and when it is present as a header for measurements.
This is the first part of reworking how comments are handled. This covers the 'comments' column under the stratigraphy data and when it is present as a header for measurements.
Store comments found in the header or passed in as an uploader option on the site record column.
aaarendt
requested changes
Jun 18, 2025
Contributor
aaarendt
left a comment
aaarendt
left a comment
There was a problem hiding this comment.
Several of the layers tests fail due to no mapping for pit_comments but when I add:
PIT COMMENTS:
code: pit_comments
description: Comments about the pit
map_from:
- pit_comments
match_on_code: true
auto_remap: true
to metadata_variable_overrides.yaml they work.
Member
Author
Nice catch and I forgot to mention that. I am leaning towards fixing that in insitupy as it has a 'pit comments' mapping in there and is improperly defined without the underscore. I logged an issue that an underscore should not break the mapping |
micah-prime
reviewed
Jun 18, 2025
micah-prime
reviewed
Jun 18, 2025
micah-prime
approved these changes
Jun 18, 2025
Member
Author
|
Related: M3Works/insitupy#27 |
The test was passing when the whole class was run. Individually it would fail.
Pass in the current active session to the helper, so we can lazily load associations of the returned object.
Use the record association definition to verify the results.
Member
Author
|
The test suite for layers is now 🟢 again. |
Merged
aaarendt
approved these changes
Jul 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note that this only addresses the 'comments' as a column in the data or when passed in as
kwargwith the parser. There is more work to be done to also parse the comments as part of the header/metadata fields.Noting here that the identifier also changed between 2020 and 2021, where it was
# Comments:,(2020) and# Comments,.Needs SnowEx/snowexsql#191