Fix: Write method in localfile server to return stream closure instead of nil#611
Merged
sfc-gh-pkowalewski merged 1 commit intomainfrom Mar 12, 2026
Merged
Conversation
sfc-gh-ksmogor
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Returning nil without calling SendAndClose on a client-streaming RPC is a protocol violation, the client expects a response message. Depending on the gRPC implementation and client behavior, the old code could have caused the client to receive an error (e.g., io.EOF without a response) or behave unpredictably on success. This fix ensures the client reliably receives a proper success acknowledgment.
This is a bug fix as it aligns Write with the correct gRPC client-streaming pattern (receive messages, then SendAndClose with a response) which is enforced by newer versions of go/grpc.