Fix: Add tolerating gRPC cardinality violations for backwards server compatibility#612
Merged
sfc-gh-pkowalewski merged 3 commits intomainfrom Mar 13, 2026
Conversation
sfc-gh-pkowalewski
force-pushed
the
pkowalewski-cardinality-violation-backwards-compatibility
branch
from
d5166f2 to
5223594
Compare
sfc-gh-pkowalewski
changed the title
sfc-gh-pkowalewski
force-pushed
the
pkowalewski-cardinality-violation-backwards-compatibility
branch
from
5223594 to
20c3251
Compare
sfc-gh-pkowalewski
force-pushed
the
pkowalewski-cardinality-violation-backwards-compatibility
branch
from
04aea18 to
2f3b0ba
Compare
…compatibility for direct connections
sfc-gh-pkowalewski
force-pushed
the
pkowalewski-cardinality-violation-backwards-compatibility
branch
from
2f3b0ba to
531cf3d
Compare
sfc-gh-ksmogor
approved these changes
Mar 13, 2026
Collaborator
sfc-gh-ksmogor
left a comment
sfc-gh-ksmogor
left a comment
There was a problem hiding this comment.
The change looks good right now. Could you regenrate all .pb.go files. Take a look here and run the script https://github.com/Snowflake-Labs/sansshell/blob/main/README.md#environment-setup--protoc-plugins.
sfc-gh-pkowalewski
deleted the
pkowalewski-cardinality-violation-backwards-compatibility
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added cardinality violation handling in
proxy/server/target.goso the proxy synthesizes the missing empty response when talking to old servers that still have the return nil bug. This makes the new proxy+client backward compatible with pre-fix servers. Same for direct client to server connections.