Turn Exception in from_element and to_element into DIDLMetadataError#601
Merged
ghcs27 merged 1 commit intoSoCo:masterfrom Jul 28, 2018
Merged
Turn Exception in from_element and to_element into DIDLMetadataError#601ghcs27 merged 1 commit intoSoCo:masterfrom
ghcs27 merged 1 commit intoSoCo:masterfrom
Conversation
Contributor
|
Can we merge this for 0.16? Even if it is not the best solution, it is definitely better than the status quo. (btw, not indicating that it isn't the best solution 😃) |
Member
Author
|
OK. If there are no objections, I will merge this next week. |
Contributor
|
@ghcs27 Just a friendly reminder about this one before the window closes. |
Member
Author
|
Thanks! |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR turns Exceptions and ValueErrors which are raised in from_didl_string into DIDLMetadataErrors, allowing them to be caught in the event handling code. See #567 for why this is necessary.