Event advertisement IP config#604
Merged
ghcs27 merged 2 commits intoSoCo:masterfrom May 22, 2018
bjw-s:advertise_ip
Merged
Conversation
|
This is very useful for those running in docker (not using net=host). |
Member
|
Looks good :) If there are no objections, I'll merge in a few days. |
Contributor
Author
|
Don't think there seem to be any objections 😇 |
|
Looking forward to this in fact. Without this I’m stuck with the home assistant polling fallback, which can take longer to trigger automations. |
ghcs27
approved these changes
May 15, 2018
Member
ghcs27
left a comment
ghcs27
left a comment
There was a problem hiding this comment.
Just marking this as approved (@stefankoegl already commented).
This should really be unproblematic.
Member
|
If there are no objections, I will merge this next week. |
Member
|
Merged. Thank you for your contribution! |
Closed
Contributor
Author
|
Thanks! I've added a post to the release notes thread. |
bjw-s
added a commit
to bjw-s/hass-config
that referenced
this pull request
Feb 7, 2020
bjw-s
added a commit
to bjw-s/hass-config
that referenced
this pull request
Feb 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recreated #450 to allow configuration of event advertisement IP.