XML escape radio station titles in play_uri#605
Merged
ghcs27 merged 1 commit intoSoCo:masterfrom May 22, 2018
Merged
Conversation
6 tasks
Contributor
Author
|
@ghcs27 I want to lose the "Needs info" label so I have added a description. However, that description does not actually contain information that was not already in the title. Please let me know if it is something else that you are looking for. |
Member
|
Thank you, it helps to have the description split into problem and solution. |
Member
|
If there are no objections, I will merge this next week. |
Member
|
Merged. Thank you for your contribution! |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The client-provided
titleargument could cause invalid XML to be generated. This change fixes that issue by escaping the value before inserting it into the generated XML.