Skip to content

CLI Overhaul #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 30 commits into from
Dec 2, 2017
Merged

CLI Overhaul #68

merged 30 commits into from
Dec 2, 2017

Conversation

@mgmarlow
Copy link
Contributor

@mgmarlow mgmarlow commented Nov 30, 2017

  • New CLI engine
  • CLI arguments and angular-playground.json file now have the same number of features (angular-playground.json takes precedence)
  • Find first available port when running check-errors to facilitate build systems
  • Reduce polling delay between check-errors connection attempts to make build faster

mgmarlow and others added 29 commits November 28, 2017 17:04
add support for argument aliases
0490f98
@mgmarlow
Merge pull request #8 from SoCreate/master
f9b7ce8 
merge
Merge branch 'master' of https://github.com/mgmarlow/angular-playground…
558e1d9 
… into cli-overhaul
cleanup
7cc2196
migrate port and timeout attempts as cli params
945f181
add method to locate first available port
f40c53a
refactor flags
9dc1066
run angular CLi now uses config flags
4915488
watch and build now don't need config dep
299709e
improve logging for timeout changes
dae462c
make find-port into an async method
e7bc6f7
fix base URL
39bec87
move ts-node and puppeteer to cli deps
0547d36
remove console logs
1fb2561
allow for nested flags
55efeb6
fix applying configuration for nested flags
63bd10c
add recursive findFlag
878ed91
get rid of unnecessary config log
0a78f9a
refactor find implementation
b2b4a3a
add default sourceRoot arg
1fa17d6
refactor applyConfig to use recursion
aca0c29
add better error reporting on check errors
315820f
abstract hex colors
60f7cae
add bamboo report output to test runner
7e0f5a8
change report type to string const for easy configuration
1f2970c
rename reporter to json reporter, tweak json output
0702740
update changelog
bfbeebe
tidy up presentation
94c39a9
add commits
c55a483
lurock
lurock requested changes Dec 2, 2017
View reviewed changes
CHANGELOG.md Outdated
* **cli:** Added a boat-load of new CLI configuration options. Every option available
in the `angular-playground.json` file is now also available as a CLI argument
(except @angular/cli arguments). [Read more about it in our docs](http://angularplayground.it/docs/api/configuration).
([9dc1066](https://github.com/SoCreate/angular-playground/pull/68/commits/9dc1066))
Copy link
Contributor

@lurock lurock Dec 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The base URLS on all of these should be https://github.com/SoCreate/angular-playground/commit/ and not https://github.com/SoCreate/angular-playground/pull/68/commits

@lurock lurock merged commit 53bf10e into SoCreate:master Dec 2, 2017
@mgmarlow mgmarlow mentioned this pull request Dec 2, 2017
Closed
@mgmarlow mgmarlow deleted the cli-overhaul branch December 11, 2017 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lurock lurock lurock approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mgmarlow @lurock