reveal to user thrown error for issue #95 #96
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgmarlow
approved these changes
Feb 22, 2018
lurock
approved these changes
Feb 22, 2018
danielkresta
pushed a commit
to danielkresta/angular-playground
that referenced
this pull request
Oct 10, 2018
reveal to user thrown error for issue SoCreate#95
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It didn't seem quite correct to handle the error in the write function defined a couple lines below. But maybe at I should be adding "[ng serve]" to the beginning of the error message so it matches the other error messages.
I also didn't add process.exit(1) to the catch block but maybe that would be useful.